Skip to content
This repository was archived by the owner on Jul 31, 2020. It is now read-only.

feat: Add a utility method synchronizeState which syncs scenes and groups.#57

Merged
ProbablePrime merged 9 commits intomasterfrom
feature/sync-state
Jun 7, 2017
Merged

feat: Add a utility method synchronizeState which syncs scenes and groups.#57
ProbablePrime merged 9 commits intomasterfrom
feature/sync-state

Conversation

@ProbablePrime
Copy link
Contributor

@ProbablePrime ProbablePrime commented Jun 2, 2017 •
edited
Loading

resolves #54

@ProbablePrime
feat: Add a utility method synchronizeState which syncs scenes and …
31abcf3 
…groups.

A lot of our examples did the same thing as a promise chain, it made sense to create a utility method.
@ProbablePrime
correct comment
fa20fe4
@kateract
Copy link
Contributor

kateract commented Jun 2, 2017

The Promise.all returns a [IGroup[], IScene[]], would it be better to return that instead of void or just too confusing? My in progress commit

@ProbablePrime
Copy link
Contributor Author

ProbablePrime commented Jun 2, 2017

Actually yeah that would be better. When working on an issue please let me know we can assign it to you :)

I'll close this and assign the issue to you if thats ok :D?

@ProbablePrime
Copy link
Contributor Author

ProbablePrime commented Jun 2, 2017

@kateract

@kateract kateract mentioned this pull request Jun 2, 2017
Merged
kateract and others added 2 commits June 3, 2017 19:55
@kateract @ProbablePrime
Change return type for synchronizeState to [IGroup[], IScene[]] (#58)
133051e 
* add syncScenes

* attempt to add tests

* merge changes

* added trailing comma for linting
@ProbablePrime
spelling
30ef0f5
@ProbablePrime
Copy link
Contributor Author

ProbablePrime commented Jun 3, 2017

Ok got the tests working. but some other tests are promise rejections

@ProbablePrime ProbablePrime merged commit 773a1e0 into master Jun 7, 2017
@ProbablePrime ProbablePrime deleted the feature/sync-state branch June 7, 2017 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@connor4312 connor4312 Awaiting requested review from connor4312

@SimonSchick SimonSchick Awaiting requested review from SimonSchick

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a catchall sync method

2 participants

@ProbablePrime @kateract